Repository navigation
Make graphics_detector build on multiple platforms - #3441
Merged
Merged
Conversation
Here, a Linux syscall is made and a fallback used if the kernel version doesn't support the syscall. But this doesn't consider that we may not be running on Linux, so forcibly return an error in this case. While we are here, tidy includes.
jmacnak
approved these changes
Oct 27, 2026
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
Oct 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Here, a Linux syscall is made and a fallback used if the kernel version doesn't support the syscall. But this doesn't consider that we may not be running on Linux, so forcibly return an error in this case.
While we are here, tidy includes.